Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Template] operations/nlb-access-logs-anonymizer - Anonymize NLB Access Log #425

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[New Template] operations/nlb-access-logs-anonymizer - Anonymize NLB Access Log #425

wants to merge 4 commits into from

Conversation

michaelwittig
Copy link
Contributor

@michaelwittig michaelwittig commented Apr 14, 2020 •
edited
Loading

andreaswittig
andreaswittig approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@andreaswittig andreaswittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

operations/nlb-access-logs-anonymizer.yaml
MemorySize: 1024
Role: !GetAtt 'Role.Arn'
Runtime: 'nodejs12.x'
Timeout: 300
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you confident, that 300s are sufficient even for larger log files?

@michaelwittig michaelwittig self-assigned this Apr 21, 2020
andreaswittig
andreaswittig approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@andreaswittig andreaswittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaswittig andreaswittig andreaswittig approved these changes

Assignees

@michaelwittig michaelwittig

Labels
Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelwittig @andreaswittig