Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce KMS-SSE requests to CloudTrail bucket #736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ab77
Copy link
Contributor

@ab77 ab77 commented Feb 8, 2024

(Override all values in parentheses)

(Run yamllint folder/template.yaml, cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, and aws cloudformation validate-template --template-body file://folder/template.yaml before you open a PR)

(Do not include multiple changes in one PR. Open additional PRs instead.)


Add bucket policy to enforce encryption by default using S3-SSE key. Required by ISO 27001 2022/SOC 2/GDPR controls:

  • AC-10
  • C-01
  • GDPR-15
  • GDPR-23

@ab77 ab77 force-pushed the ab77/cloudtrail-sse branch from 71a8deb to 60d9e7c Compare February 8, 2024 18:56
Copy link
Contributor

@michaelwittig michaelwittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi added one tiny comment. I like the overall idea!

security/cloudtrail.yaml Outdated Show resolved Hide resolved
@ab77 ab77 force-pushed the ab77/cloudtrail-sse branch from be5ffbd to c62e8dc Compare February 12, 2024 17:04
@ab77 ab77 requested a review from michaelwittig February 12, 2024 17:35
@ab77 ab77 changed the title enforce S3-SSE requests to CloudTrail bucket enforce KMS-SSE requests to CloudTrail bucket Feb 12, 2024
@ab77 ab77 force-pushed the ab77/cloudtrail-sse branch 2 times, most recently from 2254d9c to ac04ad2 Compare February 13, 2024 15:08
@ab77 ab77 force-pushed the ab77/cloudtrail-sse branch from ac04ad2 to bac64c3 Compare October 25, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants