Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow CloudFront logging to access KMS key #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ab77
Copy link
Contributor

@ab77 ab77 commented Feb 27, 2024

CloudFront doesn't appear to (currently) set SSE/KMS parameters on its access log write requests to S3, so a deny policy prevents logs from being written, even though encryption would happen regardless.

(Override all values in parentheses)

(Run yamllint folder/template.yaml, cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, and aws cloudformation validate-template --template-body file://folder/template.yaml before you open a PR)

(Do not include multiple changes in one PR. Open additional PRs instead.)


allow CloudFront to use SSE-KMS to write access logs to such buckets (using bucket keys)

@michaelwittig
Copy link
Contributor

Hi @ab77 To better understand your use case, could you help me with a quick overview of thje templates you try to bombine and the parameters you are using? Thanks, Michael

@ab77
Copy link
Contributor Author

ab77 commented Mar 4, 2024

Hi @ab77 To better understand your use case, could you help me with a quick overview of the templates you try to bombine and the parameters you are using? Thanks, Michael

Hello, this is just enabling CF logs to be written to encrypted buckets as per their docs. I added a new input to separate CloudFront hosting from CloudFront logging buckets as they are two different things. Do you want me to remove the input and assume to always force SSE?

CloudFront doesn't appear to (currently) set SSE/KMS parameters on its
access log write requests to S3, so a deny policy prevents logs from being
written, even though encryption would happen regardless.
@ab77 ab77 force-pushed the ab77/cloudfront-sse branch from 98d016b to fa2c078 Compare October 25, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants