Refactor: Use vector for dynamic array size, add input validation, and modularize average calculationRefactor

arrays/.cph/.AverageArray.cpp_975744cc3aafae3960c87a87573b381e.prob

@@ -0,0 +1 @@
+{"name":"Local: AverageArray","url":"c:\\Users\\dinesh mishra\\OneDrive\\New_Folder\\HacktoberFest-2022\\arrays\\AverageArray.cpp","tests":[{"id":1723896197036,"input":"","output":""}],"interactive":false,"memoryLimit":1024,"timeLimit":3000,"srcPath":"c:\\Users\\dinesh mishra\\OneDrive\\New_Folder\\HacktoberFest-2022\\arrays\\AverageArray.cpp","group":"local","local":true}

arrays/AverageArray.cpp

@@ -1,19 +1,38 @@
-//Calculate Average of Array
-#include<bits/stdc++.h>
+#include <iostream>
+#include <vector>
+#include <numeric> // for accumulate
+#include <limits>  // for numeric_limits
+
 using namespace std;
-int main(){
 
-	int a[100],sum=0,n;
-	cout<<"How many element: ";
-	cin>>n;
-	cout<<"Enter numbers: ";
-	for(int i=0;i<n;i++){
-		cin>>a[i];
-	}
-	for(int i=0;i<n;i++){
-		sum+=a[i];
-	}
-	cout<<"Average is : "<<(float)sum/n<<endl;
+float calculateAverage(const vector<int>& numbers) {
+    int sum = accumulate(numbers.begin(), numbers.end(), 0);
+    return static_cast<float>(sum) / numbers.size();
+}
+
+int main() {
+    int n;
+    cout << "How many elements: ";
+    cin >> n;
+
+    // Error handling for invalid input
+    if (n <= 0) {
+        cout << "Number of elements must be positive!" << endl;
+        return 1;
+    }
+
+    vector<int> a(n);
+    cout << "Enter numbers: ";
+    for (int i = 0; i < n; i++) {
+        while (!(cin >> a[i])) {
+            cin.clear(); // clear the error flag
+            cin.ignore(numeric_limits<streamsize>::max(), '\n'); // ignore the invalid input
+            cout << "Invalid input. Please enter an integer: ";
+        }
+    }
 
+    float average = calculateAverage(a);
+    cout << "Average is: " << average << endl;
 
+    return 0;
 }

arrays/alternateArrays.cpp

@@ -31,7 +31,7 @@ int main()
     alternateArray(arr, size);
     for (int i = 0; i < size; i++)
     {
-        cout << arr[i];
+        cout << arr[i] << " ";
     }
     return 0;
 }

arrays/arraysum.cpp

@@ -3,7 +3,7 @@ using namespace std;
 
 int main() {
     int a[] = {2, 4, 6, 8}; //integer array
-    int len = sizeof(x) / sizeof(a[0]); //get array length
+    int len = sizeof(a) / sizeof(a[0]); //get array length
     int sum = 0; //initialize sum with 0
 
     for (int i = 0; i < len; i++) {

contributorList.txt

@@ -3,3 +3,4 @@ Sahil Kumar @HAXAZE
 SHRUTI RANI @ShrutiRani7029
 Sahan Chandrabahu @SahanChandrabahu
 Manasij Haldar  @TheROCKoManz
+VARSHA @Varshamishra56