[WFCORE-6548] Unify test logging in elytron module #5705
Conversation
github-actions
bot
added
the
deps-ok
| @@ -7,7 +7,7 @@ | |||
| loggers=org.wildfly.extension.elytron,org.apache.directory,net.sf.ehcache,org.apache.directory.api.ldap,javax.security.sasl,org.wildfly.security,org.wildfly.security.sasl,org.wildfly.security.xml,org.wildfly.security.tls | |||
|
|
|||
| # Root logger configuration | |||
| logger.level=${test.level:TRACE} | |||
| logger.level=INFO | |||
There was a problem hiding this comment.
Maybe the Elytron team is used to using this config -Dtest.level
@OndrejKotek is there any reason for not using logger.level=${test.level:INFO} instead?
There was a problem hiding this comment.
I have taken other similar logging configurations into account and tried to find the best solution. I think the maximum levels of the most important loggers are set below and the logging level for Elytron tests is handled through handler.CONSOLE.level=${test.level:INFO}.
There was a problem hiding this comment.
@OndrejKotek Thanks for the explanation. This seems ok then. @yersan WDYT?
There was a problem hiding this comment.
Thanks for reviewing @fjuma. I am fine with this too then.
The change here is now only the loggers declared in the loggers configuration will be taken into account by the CONSOLE handler when the level changes to something different than INFO. The root logger will be always INFO. That's more clear handling since it takes into account only the loggers you want for your tests avoiding the root logger.
There was a problem hiding this comment.
Threads and installation-manager could use the same approach, that's a different Jira, I will create one
yersan
added
the
ready-for-merge
|
Thanks @fjuma @OndrejKotek |
https://issues.redhat.com/browse/WFCORE-6548