WFCORE-6332: clean up license config files #5707
Merged
+10
−2,059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
michpetrov
force-pushed
the
wfcore-6332
branch
from
c5fa40d to
4139e4e
Compare
github-actions
bot
added
the
deps-ok
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
michpetrov
force-pushed
the
wfcore-6332
branch
from
4139e4e to
434a62a
Compare
|
@michpetrov Could you please also address Brian's comment done in https://issues.redhat.com/browse/WFLY-18059? jboss-vfs is a dependency managed by WildFly Core and has not been resolved yet. Addressing that will help with the review since there are a lot of pieces involved here. Thanks. |
|
@yersan I have filed https://issues.redhat.com/browse/JBVFS-220, but it is not necessary for this issue. When jboss-vfs gets upgraded the record can be deleted. |
yersan
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Thanks @michpetrov
When jboss-vfs gets upgraded the record can be deleted.
Could you create a WFCORE Jira blocked by JBVFS-220, to track it so we do not forget to complete this work?
yersan
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR pending new release of the license pluginIssue: WFCORE-6332