Adding new assertFailureWith #525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Mar 27, 2024
assertk/src/commonTest/kotlin/test/assertk/AssertFailureTest.kt
Outdated
Show resolved
Hide resolved
|
This addresses #511. |
JakeWharton
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
I would prefer this variant of assertFailure, but it was asked to be omitted when that function was first introduced. You'll have to wait to hear from a maintainer on #511
Comment on lines
+200
to
+202
| assertFailure.isInstanceOf(T::class) | ||
| @Suppress("UNCHECKED_CAST") | ||
| return assertFailure as Assert<T> |
There was a problem hiding this comment.
This returns a specialized Assert with the new type
Suggested change
| assertFailure.isInstanceOf(T::class) | |
| @Suppress("UNCHECKED_CAST") | |
| return assertFailure as Assert<T> | |
| return assertFailure.isInstanceOf(T::class) |
| /** | ||
| * Asserts the throwable with a specific type have the expected properties for it. | ||
| */ | ||
| fun <T: Throwable> Assert<T>.hasProperties(vararg pairs: Pair<KProperty1<T, Any>, Any>) { |
There was a problem hiding this comment.
This is unrelated to assertFailsWith. It's not clear why it's type parameter is bound to Throwable subtypes since it's a general-purpose utility. I would separate it into its own PR, or even start with an issue discussing the use case and why regular .all { } in insufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the new
assertFailureWithto assert exception with a specific type and verify properties of this type.