Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CLI #50

Closed
wants to merge 10 commits into from
Closed

WIP: CLI #50

wants to merge 10 commits into from

Conversation

aaron-goff
Copy link
Collaborator

@aaron-goff aaron-goff commented May 15, 2020

Add the CLI stuff
Closes #49

Core functionality is more or less there. If you want to play with this on your own...

  • pull it down

  • inside the project run npm link

  • execute commands through rr --name-of-command argsWithCommand

    • List of commands is in args.ts
  • Created issue Make tests around CLI #52 to track eventually making the tests.

Add pretty printing
Add types
Add helpers
Finish adding commands
Fix error in RokulRunnings
Copy link
Contributor

@mcmillhj-wta mcmillhj-wta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments, over the CLI looks really good.

package.json Outdated Show resolved Hide resolved
src/commandLine/CommandLine.ts Outdated Show resolved Hide resolved
src/commandLine/CommandLine.ts Outdated Show resolved Hide resolved
src/modules/RokulRunnings.ts Outdated Show resolved Hide resolved
Refactor command line to use common function
Make logic more clear in command line
Add command line documentation
Add sideload to command line

## Global vs. Local

Rokul Runnings CLI uses simple logic to determine what config file to use. If the present working directory that the command is executed from contains a file named `rrconfig.json`, then that file is used. Otherwise, the global config file will be used. This will look something like FIND OUT WHAT IT LOOKS LIKE.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment so I actually come back and update this.

@aaron-goff aaron-goff closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate adding CLI options
3 participants