-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: CLI #50
Closed
Closed
WIP: CLI #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pretty printing Add types Add helpers Finish adding commands Fix error in RokulRunnings
aaron-goff
requested review from
mcmillhj-wta,
rothomp3,
tommydvelopment,
madeleine-adams and
chiller-whale
May 20, 2020 21:19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a handful of comments, over the CLI looks really good.
Refactor command line to use common function
Make logic more clear in command line Add command line documentation Add sideload to command line
aaron-goff
commented
May 27, 2020
|
||
## Global vs. Local | ||
|
||
Rokul Runnings CLI uses simple logic to determine what config file to use. If the present working directory that the command is executed from contains a file named `rrconfig.json`, then that file is used. Otherwise, the global config file will be used. This will look something like FIND OUT WHAT IT LOOKS LIKE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment so I actually come back and update this.
aaron-goff
commented
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the CLI stuff
Closes #49
Core functionality is more or less there. If you want to play with this on your own...
pull it down
inside the project run
npm link
execute commands through
rr --name-of-command argsWithCommand
args.ts
Created issue Make tests around CLI #52 to track eventually making the tests.