363: Selects the next non-hidden category to display when the currently-displayed category is hidden #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splayed category is hidden
cinadia
requested review from
nicholas-cook,
stechkev,
nerdsosky,
caroline-wang-320,
PaulKlauser and
mattttvaughn
as code owners
PaulKlauser
requested changes
May 24, 2024
PaulKlauser
requested changes
Jun 3, 2024
PaulKlauser
approved these changes
Jun 4, 2024
| category | ||
| ) | ||
|
|
||
| } |
There was a problem hiding this comment.
THESE 👏 ARE 👏 SO 👏 GOOD
PaulKlauser
reviewed
Jun 4, 2024
| category = it | ||
| } | ||
| } | ||
| job.cancel() |
There was a problem hiding this comment.
I just brought in Turbine to make this less obnoxious, could be fun to refactor this later and see how much nicer turbine makes things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a user hides the currently-displayed category, looks for and select the next non-hidden category. Displays the Category label and Phrases of the newly-selected, non-hidden category.
Defaults to looking for the next non-hidden category to the "right".
Addresses #363