New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#566 (band-aid, not permanent fix): Edit Phrases list scrolls vertically #576

Merged

kaffn8ed27 merged 1 commit into main from bugfix/edit_phrase_should_not_vertical_scroll

Jul 19, 2024

Collaborator

kaffn8ed27 commented Jul 19, 2024 •

edited

Loading

Description:

Reduces the max number of phrases on screens with smallest width less than 400dp
I am working on (hopefully) a much larger dynamic fix (measuring views vs. available space), but the goal of this PR is to get a quick fix out that should prevent problems for most real-world users


          Reduces # of editable phrases displayed on small screens

0a1dc1d

kaffn8ed27 requested review from nicholas-cook, stechkev, nerdsosky, PaulKlauser and mattttvaughn as code owners

July 19, 2024 15:23

mattttvaughn approved these changes

View reviewed changes

kaffn8ed27 merged commit 487ac50 into main

5 checks passed

kaffn8ed27 deleted the bugfix/edit_phrase_should_not_vertical_scroll branch

July 19, 2024 16:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattttvaughn mattttvaughn approved these changes

nicholas-cook Awaiting requested review from nicholas-cook nicholas-cook is a code owner

stechkev Awaiting requested review from stechkev stechkev is a code owner

nerdsosky Awaiting requested review from nerdsosky nerdsosky is a code owner

PaulKlauser Awaiting requested review from PaulKlauser PaulKlauser is a code owner

Labels

None yet