fix: Reload the service when needed #303
Conversation
|
For the record, the CI issues are fixed in #304 so once it will be in, we can rebase this. |
Some changes, such as sysconfig change, requires the service to be restarted. Fixes: willshersystems#302 Signed-off-by: Jakub Jelen <[email protected]>
The documentation says there is only one global scope for handlers: > There is only one global scope for handlers (handler names and listen topics) > regardless of where the handlers are defined. This also includes handlers > defined in roles. So following the naming convention as we do in all the other variables sounds like a good idea. https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_handlers.html Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
restart-on-sysconfig-change
branch
from
5bc4577 to
86ea486
Compare
|
(rebased to address the CI issues) |
|
Right. This change will have the same issue as the #236, which I already forgot about. Let me have a look into that. |
This did not work since 43ed7c1, for over 7 years so instead of restoring this behavior, updating documentation to match current beharior sounds more reasonable. Fixes: willshersystems#236 Signed-off-by: Jakub Jelen <[email protected]>
Fixes: willshersystems#301 Signed-off-by: Jakub Jelen <[email protected]>
Co-authored-by: Matt Willsher <[email protected]>
|
All good - please merge when ready 👍🏼 |
|
Thank you for comments and reviews! I am not sure if we merge by rebasing/merge commit or squashing to keep the automation working correctly so I will leave the merge on you or Rich. |
|
By squash to preserve the |
|
The automation works with PR titles, not with commits. Commits can have any format, they should not be consistent with PR titles. |
|
Thanks for clarification. Then I will do rebase & merge to preserve the commits. |
The change of sysconfig requires the full restart instead of only reload.
I did not figure out a better way to avoid doing both in this case, so comments and suggestions welcomed.
Fixes: #302