Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: WINDUP-1710 - e2e testing #526

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

klinki
Copy link
Collaborator

@klinki klinki commented Oct 6, 2017

  • add more test scenarios (project list filtering)

@mrizzi
Copy link
Member

mrizzi commented Oct 23, 2017

Tested code from commit dbda508:

  • some tests are failing "Executed 39 of 42 specs (11 FAILED) (3 SKIPPED) in 6 mins" from the tests/e2e/target/e2e-output.log (attached)
  • after the end of failed tests, the Wildfly instance is still running so trying to run another time the test fails immediately with the message
[ERROR] Failed to execute goal org.wildfly.plugins:wildfly-maven-plugin:1.2.0.Final:start (start-wildfly) on project windup-tests-e2e: STANDALONE server is already running?
  • i was not able to have the "junit style" file in output, maybe am i missing some flag?

@klinki klinki force-pushed the WINDUP-1710-e2e-testing branch from 909f2bb to 828283b Compare October 31, 2017 13:14
@klinki klinki force-pushed the WINDUP-1710-e2e-testing branch from 828283b to d770b1a Compare October 31, 2017 13:58
Use failsafe plugin to run integration tests.
- pre-integration-test phase starts server
- interation-test phase executes the tests
- post-integration-test phase stops server

There are several workarounds required to do that:
- maven exec of protractor tests must accept failure status code (1) as
success
- there must be another script, which parses test-results.xml and
creates failsafe-report.xml from it
- failsafe then runs verify phase and checks failsafe report. If test
failures are found, it fails the maven execution safely (it runs
post-integration-test phase and stops server first)
SchedulerService provides more convenient way of running these async
callbacks and internally implements setInterval, setTimeout functions
to run outside of angular zone. This is required for protractor tests.

Also SchedulerService provides easier testability and maintainability.
Remove headless mode to demonstrate e2e tests visually.
@klinki klinki force-pushed the WINDUP-1710-e2e-testing branch from 16a70c9 to 7f33691 Compare November 1, 2017 11:35
@windupgithubbot1
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants