-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: WINDUP-1710 - e2e testing #526
Open
klinki
wants to merge
24
commits into
windup:master
Choose a base branch
from
klinki:WINDUP-1710-e2e-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
klinki
commented
Oct 6, 2017
- add more test scenarios (project list filtering)
klinki
force-pushed
the
WINDUP-1710-e2e-testing
branch
from
October 18, 2017 12:16
3085a4c
to
d4b914b
Compare
Tested code from commit dbda508:
[ERROR] Failed to execute goal org.wildfly.plugins:wildfly-maven-plugin:1.2.0.Final:start (start-wildfly) on project windup-tests-e2e: STANDALONE server is already running?
|
Retry login attempt on failure
wait for analysis Fix analysis list Update waiting until analysis finishes
Fix waiting for progressbar
klinki
force-pushed
the
WINDUP-1710-e2e-testing
branch
from
October 31, 2017 13:14
909f2bb
to
828283b
Compare
Add copy tasks Update pom.xml - unzip reports
klinki
force-pushed
the
WINDUP-1710-e2e-testing
branch
from
October 31, 2017 13:58
828283b
to
d770b1a
Compare
Use failsafe plugin to run integration tests. - pre-integration-test phase starts server - interation-test phase executes the tests - post-integration-test phase stops server There are several workarounds required to do that: - maven exec of protractor tests must accept failure status code (1) as success - there must be another script, which parses test-results.xml and creates failsafe-report.xml from it - failsafe then runs verify phase and checks failsafe report. If test failures are found, it fails the maven execution safely (it runs post-integration-test phase and stops server first)
SchedulerService provides more convenient way of running these async callbacks and internally implements setInterval, setTimeout functions to run outside of angular zone. This is required for protractor tests. Also SchedulerService provides easier testability and maintainability.
Remove headless mode to demonstrate e2e tests visually.
klinki
force-pushed
the
WINDUP-1710-e2e-testing
branch
from
November 1, 2017 11:35
16a70c9
to
7f33691
Compare
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.