Fix Stan issues

wintercms · Jul 29, 2024 · 3fcb603 · 3fcb603
1 parent c82a43f
commit 3fcb603
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 119 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -155,16 +155,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/AttachMany.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/AttachMany.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/AttachMany.php
-
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\Relation\\:\\:withDefault\\(\\)\\.$#"
 			count: 1
@@ -185,16 +175,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/AttachOne.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/AttachOne.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/AttachOne.php
-
 		-
 			message: "#^Call to private method delete\\(\\) of parent class Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\MorphOne\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\.$#"
 			count: 3
@@ -225,16 +205,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/BelongsTo.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/BelongsTo.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/BelongsTo.php
-
 		-
 			message: "#^Access to an undefined property Illuminate\\\\Database\\\\Eloquent\\\\Model\\:\\:\\$sessionKey\\.$#"
 			count: 1
@@ -300,16 +270,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/BelongsToMany.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/BelongsToMany.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/BelongsToMany.php
-
 		-
 			message: "#^Parameter \\#2 \\$columns of method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\:\\:paginate\\(\\) expects array, int\\|null given\\.$#"
 			count: 1
@@ -385,16 +345,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/HasMany.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasMany.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasMany.php
-
 		-
 			message: "#^Call to private method update\\(\\) of parent class Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\HasMany\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\.$#"
 			count: 1
@@ -425,16 +375,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/HasManyThrough.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasManyThrough.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasManyThrough.php
-
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\Relation\\:\\:withDefault\\(\\)\\.$#"
 			count: 1
@@ -450,16 +390,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/HasOne.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasOne.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasOne.php
-
 		-
 			message: "#^Call to private method update\\(\\) of parent class Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\HasOne\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\.$#"
 			count: 2
@@ -480,16 +410,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/HasOneThrough.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasOneThrough.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/HasOneThrough.php
-
 		-
 			message: "#^Instanceof between \\*NEVER\\* and Winter\\\\Storm\\\\Database\\\\Relations\\\\HasManyThrough will always evaluate to false\\.$#"
 			count: 4
@@ -515,15 +435,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/MorphMany.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphMany.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphMany.php
 
 		-
 			message: "#^Call to private method update\\(\\) of parent class Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\MorphMany\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\.$#"
@@ -560,16 +471,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/MorphOne.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphOne.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphOne.php
-
 		-
 			message: "#^Call to private method update\\(\\) of parent class Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\MorphOne\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\.$#"
 			count: 2
@@ -600,16 +501,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/MorphTo.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphTo.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphTo.php
-
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Relations\\\\Relation\\:\\:withDefault\\(\\)\\.$#"
 			count: 1
@@ -635,16 +526,6 @@ parameters:
 			count: 1
 			path: src/Database/Relations/MorphToMany.php
 
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:getForeignKey\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphToMany.php
-
-		-
-			message: "#^Call to an undefined method Winter\\\\Storm\\\\Database\\\\Relations\\\\Relation\\:\\:select\\(\\)\\.$#"
-			count: 1
-			path: src/Database/Relations/MorphToMany.php
-
 		-
 			message: "#^Parameter \\#2 \\$columns of method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\<Illuminate\\\\Database\\\\Eloquent\\\\Model\\>\\:\\:paginate\\(\\) expects array, int\\|null given\\.$#"
 			count: 1

diff --git a/phpstan.neon b/phpstan.neon
@@ -12,6 +12,10 @@ parameters:
         - src/Parse/PHP/ArrayPrinter.php
         - src/Foundation/Console/KeyGenerateCommand.php
         - src/Scaffold/GeneratorCommand.php
+    ignoreErrors:
+        - message: '#Call to private method select\(\)#'
+          paths:
+            - src/Database/Relations/Concerns/CanBeCounted.php
     disableSchemaScan: true
     databaseMigrationsPath:
         - src/Auth/Migrations