Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlayerUse event issues #3171

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

Denneisk
Copy link
Member

@Denneisk Denneisk commented Nov 8, 2024

  • Added PlayerUse hook called on pod controllers' use action
  • Fixed event playerUse would not run when ran in a hook

Fixes #3121

@thegrb93
Copy link
Contributor

thegrb93 commented Nov 8, 2024

can KeyPress or KeyRelease hooks be used instead?

@Denneisk
Copy link
Member Author

Denneisk commented Nov 8, 2024

Not to the same effect, because they both run before the PlayerUse hook. But, thanks to your input, I discovered a solution that's embarrassingly simple.

@Denneisk
Copy link
Member Author

Denneisk commented Nov 8, 2024

This however has the caveat that it doesn't run if the player continues to hold E but also runs Entity:Use, so it's not perfect...

Edit: So did the other one. What am I saying? I'm getting too invested in this...

@thegrb93 thegrb93 merged commit b9cca7a into wiremod:master Nov 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event playerUse does not account for pod's Allow Buttons
2 participants