WireLib.clampPos/Force optimization #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up WireLib.clampPos by about 2x and WireLib.clampForce by about 5x
thegrb93
requested changes
Dec 15, 2024
Denneisk
approved these changes
Dec 15, 2024
|
Can you use unpack in clampPos too? |
thegrb93
approved these changes
Dec 16, 2024
|
how does this change handle NaN |
|
print(math.Clamp(0/0, -100, 100))... |
|
so someone fixed it in gmod, then, since we had these checks in place specifically because clamp didn't handle it previously. looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up WireLib.clampPos by about 2x and WireLib.clampForce by about 5x