Define curried data constructor via Quark.Partial.defpartial
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defpartial/2` is called with `args_without_defaults` because
`defpartial/2` is implemented using `defcurry/2` which would pass args
with defaults to an anonymous function, but:
```elixir
== Compilation error in file lib/algae/tree/rose.ex ==
** (CompileError) lib/algae/tree/rose.ex:34: anonymous functions cannot have optional ar
guments
(stdlib) lists.erl:1354: :lists.mapfoldl/3
(elixir) src/elixir_fn.erl:19: :elixir_fn.expand/3
lib/algae/tree/rose.ex:34: (module)
```
On the other hand, it doesn't seem to be logical to have defaults when
currying anyway:
```elixir
defmodule Person do
defdata do
name :: string
age :: integer
end
end
Person.new_partial.("lofa")
```
I would expect the last expression to return a function instead of
`%Person{name: "lofa", age: 0}`.
toraritte
changed the title
Quark.Partial.defpartial (#45)Quark.Partial.defpartial
|
Yeah, that's super cool 👍 Just doing some maintenance, and will try to get this in shortly |
|
Thanks a lot for this project and for all your hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For issue #45)
defpartial/2is called withargs_without_defaultsbecausedefpartial/2is implemented usingdefcurry/2which would pass args with defaults to an anonymous function, and result in:On the other hand, it doesn't seem to be logical to have defaults when currying anyway:
I would expect the last expression to return a function instead of
%Person{name: "lofa", age: 0}.edit: Only modified the
def data_ast(lines, ...)clause ininternal.exto wait for feedback.