Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invoke vite.build with up to date configuration during astro:bui… #12763

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rbsummers
Copy link
Contributor

…ld:setup hook when target is "client"

Changes

  • Make astro:build:setup hook actually consume and use the updated configuration provided by integrations using the updateConfig function when building for client target.

Testing

Manual tests only for now.

Docs

Complementary changes in docs by @ematipico on withastro/docs#10410
/cc @withastro/maintainers-docs

Closes #12372

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: f1e1a9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 17, 2024
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #12763 will degrade performances by 20.64%

Comparing rbsummers:main (f1e1a9b) with main (95795f8)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rbsummers:main Change
Rendering: streaming [false], .astro file 1.2 s 1.5 s -20.64%
Rendering: streaming [false], .md file 18.4 ms 14.7 ms +25.23%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix!

@ematipico ematipico merged commit 8da2318 into withastro:main Dec 17, 2024
14 of 16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to updateConfig is ignored in astro:build:setup hook
2 participants