-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add error log for server islands #12768
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9c661f5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/astro/src/core/server-islands/vite-plugin-server-islands.ts
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #12768 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts on the error messages, FWIW! 🙌
packages/astro/src/core/server-islands/vite-plugin-server-islands.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/core/server-islands/vite-plugin-server-islands.ts
Outdated
Show resolved
Hide resolved
…nds.ts Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
underscore-redirects
package. Sinceconfig.output
isn't reliable anymore, I added a new field, so we can update the adapters to pass the correct valueTesting
I tested the logs locally.
Docs
/cc @withastro/maintainers-docs for feedback!