fix(DTXReactNativeSupport): JS and Content can load in any order #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously waitForReactNativeLoadWithCompletionHandler would add an observer for "RCTJavaScriptDidLoadNotification", then when notified would add a second observer for "RCTContentDidAppearNotification", and after getting a notification for both it would call the completion handler. However, with the React Native new architecture the loading of the JS and Content can happen in a different order (content first). This would cause DetoxSync to get stuck when enabling synchronization. Instead, we register all observers (JS, content, failure) one after the other, and we use a race-free C11 atomic to count when we receive a successful JS or Content notification. After we receive both (or fail), we call the handler as before.
TimotheeIsnard
force-pushed
the
fix_new_arch_bundle_load_race
branch
from
bb61ed5 to
2b04812
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, submitting a fix for a DetoxSync issue I'm running into with React Native.
This is my first PR to DetoxSync, so please let me know if I got anything wrong =)
Previously waitForReactNativeLoadWithCompletionHandler would add an observer for "RCTJavaScriptDidLoadNotification", then when notified would add a second observer for "RCTContentDidAppearNotification", and after getting a notification for both it would call the completion handler.
However, with the React Native new architecture the loading of the JS and Content can happen in a different order (content first). This would cause DetoxSync to get stuck when enabling synchronization.
Instead, we register all observers (JS, content, failure) one after the other, and we use a race-free C11 atomic to count when we receive a successful JS or Content notification.
After we receive both (or fail), we call the handler as before.