Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global access in browsers #178

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Fix global access in browsers #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c283828
Fix global access in browsers
guyca Sep 21, 2024
51ec57d
Fix lint
guyca Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-obsidian/src/graph/registry/GraphRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Graph } from '../Graph';
import { Middleware } from './Middleware';
import GraphMiddlewareChain from './GraphMiddlewareChain';
import { ObtainLifecycleBoundGraphException } from './ObtainLifecycleBoundGraphException';
import { getGlobal } from '../../utils/getGlobal';

export class GraphRegistry {
private readonly constructorToInstance = new Map<Constructable<Graph>, Set<Graph>>();
Expand Down Expand Up @@ -151,7 +152,6 @@ export class GraphRegistry {
}
}

// @ts-ignore
global.graphRegistry = global.graphRegistry || new GraphRegistry();
// @ts-ignore
export default global.graphRegistry as GraphRegistry;
const globalObject = getGlobal();
globalObject.graphRegistry = globalObject.graphRegistry || new GraphRegistry();
export default globalObject.graphRegistry as GraphRegistry;
3 changes: 3 additions & 0 deletions packages/react-obsidian/src/utils/getGlobal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function getGlobal(): any {
return typeof window !== 'undefined' ? window : global;
}
Loading