Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use options.as to determine Element in itemView #1300

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

AleksMWix
Copy link
Contributor

No description provided.

Copy link
Collaborator

@yoavtsook2806 yoavtsook2806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, why do you need this option?
What are you sending there instead of div?

Copy link
Collaborator

@yoavtsook2806 yoavtsook2806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please change the prop to an object named elementsOveride with one property at the moment: {item: ${yourElement}}. this prop should not be under 'options', but as a separated prop.
  2. Please add this API in another PR to master as well.
  3. This is the last PR which is not a bug fix that we approve for version 4 :)

@AleksMWix
Copy link
Contributor Author

#rebuild

@AleksMWix AleksMWix merged commit 28eee7d into V4_Final Dec 9, 2024
7 checks passed
@AleksMWix AleksMWix deleted the itemViewCustomElement branch December 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants