-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): make it possible to install via CocoaPods #276
Conversation
The podspec file was npm ignored, resulting in linking via CocaPods did not work
Why would this not be merged? |
This is critical to merge for React Native 0.60 :) |
+1 |
@Inbal-Tish Friendly ping 🤗 |
@Inbal-Tish could you please give a look at this PR? this is crucial to anyone upgrading to RN 0.60. thanks a lot! |
I've just installed from master in the interim to include the podspec |
Yeah, that's crucial! |
Bumping. @Inbal-Tish Can we get this approved? |
BUMP!!!!! |
bump again <3 |
@sondremare The Android build is failing. |
for build
for build
Is this repo dead? This PR was opened 7 months ago and it changes 3 lines. Seriously no one can test and approve it? It clearly has nothing to do with Android build. |
Redone in #300 - Original PR had some git reference messup (detached head, unreachable by CI, caused this PR build to fail). |
The podspec file was npm ignored, resulting in linking via CocaPods did not work