Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): make it possible to install via CocoaPods #276

Closed
wants to merge 5 commits into from

Conversation

sondremare
Copy link
Contributor

The podspec file was npm ignored, resulting in linking via CocaPods did not work

The podspec file was npm ignored, resulting in linking via CocaPods did not work
@rgoldiez
Copy link

Why would this not be merged?

@DaBs
Copy link

DaBs commented Jul 17, 2019

This is critical to merge for React Native 0.60 :)

@congnguyen91
Copy link

+1

@ahanriat
Copy link
Contributor

@Inbal-Tish Friendly ping 🤗

@ammichael
Copy link

@Inbal-Tish could you please give a look at this PR? this is crucial to anyone upgrading to RN 0.60. thanks a lot!

@alexichristakis
Copy link

I've just installed from master in the interim to include the podspec

@mtzfactory
Copy link

Yeah, that's crucial!

@brandons
Copy link

brandons commented Sep 30, 2019

Bumping. @Inbal-Tish Can we get this approved?

@keithhackbarth
Copy link

BUMP!!!!!

@darran-kelinske-fivestars

bump again <3

@Inbal-Tish
Copy link
Collaborator

@sondremare The Android build is failing.

@Inbal-Tish Inbal-Tish requested a review from rotemmiz October 22, 2019 08:29
@ammichael
Copy link

Is this repo dead? This PR was opened 7 months ago and it changes 3 lines. Seriously no one can test and approve it? It clearly has nothing to do with Android build.

@rotemmiz
Copy link
Contributor

rotemmiz commented Nov 6, 2019

Redone in #300 - Original PR had some git reference messup (detached head, unreachable by CI, caused this PR build to fail).
I am closing this PR in favour of #300. Thanks for your contribution @sondremare, we'll make sure this is merged and published ASAP.

@rotemmiz rotemmiz closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.