Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft #692
base: master
Are you sure you want to change the base?
first draft #692
Changes from 1 commit
31bd5e9
1fbdf3e
e6fad78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is not organized well. Please try to rewrite. Here are some things to keep in mind:
DOUBLEBOOKING
and talk about "disabling availability checks" or "skipping availability checks" instead of "passingskipAvailability
astrue
" ... we're in an article, not in the actual reference. You can always add a link to the place in the reference to the actual status/property either in the API Ref or in the Terminology glossary ... but the words should be regular language.-This is not structured as a sentence. Every sentence should have a subject, a verb and usually also an object. Please learn about these things - here is a site that might be helpful but I'm sure you can find other sites: https://ecampusontario.pressbooks.pub/cs050academicwritingandgrammar/chapter/subjects-and-verbs/#:~:text=Every%20complete%20sentence%20has%20both,sentence%20says%20about%20the%20subject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statuses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not reviewing every single word in the table. I will need to see the entire article again. I will just give you some quick comments. But realize that it's not a full review on the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a sentence - it should be two sentences or rewritten to be one sentence. I think if you ran every sentence through ChatGPT you'd be in a better place.
I do not understand what this means: "it can be used for checkout or processed without it."
Do we always say "business calendar?" Can we just always say "calendar?"
I don't understand what "the first step and status" means, can be worded better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In REST, the endpoints are capitalized so it would be Create Booking.
Also you are missing a period at the end of the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"You can't change a booking's status from
CREATED
toWAITING_LIST
with the Bookings V2 APIs."Huh? Is this a limitation for now? This should be in the Intro "Before you begin" section also. As is written in our guidelines in the cafe, step 6: "The section helps us inform app developers and Velo users about missing or unexpected functionality. It's important to do this before they start working. This way they won’t get stuck in the middle of their project."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding to before you begin for BV2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot your "coming soon"