fix(core): custom-value inside computed st-var #2402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
reviewed
Mar 27, 2022
There was a problem hiding this comment.
looks good, but the computed input "type" field string might be problematic since it is only the local custom value identifier in a specific stylesheet. For example stBorder might be border, stBorder or st-border, depending on how it is imported, and when looking at a var that is a composite from imported vars it would be impossible to figure out what custom value it is actually made out of.
Maybe adding the module path and export or the actual evaluated custom-value would help?
idoros
requested changes
Mar 27, 2022
|
Continued in this PR - #2422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.