Remove weirdness from Fingerprint methods #40
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| * @since 1.0 | ||
| * @license GPL-2.0+ | ||
| * @author H. Snater < [email protected] > | ||
| * @author Bene* < [email protected] > | ||
| * | ||
| * @constructor | ||
| * | ||
|
|
@@ -74,12 +75,11 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term} label | ||
| * @return {boolean} | ||
| */ | ||
| hasLabel: function( label ) { | ||
| return this._labels.hasItem( label.getLanguageCode(), label ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -91,23 +91,21 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term|null} label | ||
| */ | ||
| setLabel: function( label ) { | ||
| if ( label === null || label.getText() === '' ) { | ||
| this._labels.removeItemByKey( label.getLanguageCode() ); | ||
| } else { | ||
| this._labels.setItem( label.getLanguageCode(), label ); | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term} label | ||
| */ | ||
| removeLabel: function( label ) { | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. We also have Edit: Even |
||
| this._labels.removeItem( label.getLanguageCode(), label ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -133,12 +131,11 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term} description | ||
| * @return {boolean} | ||
| */ | ||
| hasDescription: function( description ) { | ||
| return this._descriptions.hasItem( description.getLanguageCode(), description ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -150,23 +147,21 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term|null} description | ||
| */ | ||
| setDescription: function( description ) { | ||
| if ( description === null || description.getText() === '' ) { | ||
| this._descriptions.removeItemByKey( description.getLanguageCode() ); | ||
| } else { | ||
| this._descriptions.setItem( description.getLanguageCode(), description ); | ||
| } | ||
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.Term} description | ||
| */ | ||
| removeDescription: function( description ) { | ||
| this._descriptions.removeItem( description.getLanguageCode(), description ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -192,12 +187,11 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.MultiTerm} aliases | ||
| * @return {boolean} | ||
| */ | ||
| hasAliases: function( aliases ) { | ||
| return this._aliases.hasItem( aliases.getLanguageCode(), aliases ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
@@ -209,37 +203,16 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.MultiTerm|wikibase.datamodel.MultiTermMap} aliases | ||
| */ | ||
| setAliases: function( aliases ) { | ||
| if ( aliases instanceof wb.datamodel.MultiTerm ) { | ||
| if ( aliases.isEmpty() ) { | ||
| this._aliases.removeItemByKey( aliases.getLanguageCode() ); | ||
| } else { | ||
| this._aliases.setItem( aliases.getLanguageCode(), aliases ); | ||
| } | ||
| } else if( aliases instanceof wb.datamodel.MultiTermMap ) { | ||
| this._aliases = aliases; | ||
| } else { | ||
| throw new Error( 'Aliases need to be specified as wb.datamodel.MultiTerm or ' | ||
|
|
@@ -248,11 +221,10 @@ $.extend( SELF.prototype, { | |
| }, | ||
|
|
||
| /** | ||
| * @param {wikibase.datamodel.MultiTerm} aliases | ||
| */ | ||
| removeAliases: function( aliases ) { | ||
| this._aliases.removeItem( aliases.getLanguageCode(), aliases ); | ||
| }, | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @JeroenDeDauw said this should be hasLabel: function( languageCode ).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we already have
hasLabelForbelow which does exactly that. We could just remove this method but I think it is useful if you don't only want to check if a label is set but also compare it to the value passed here.