-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Make the whole data model immutable #54
base: master
Are you sure you want to change the base?
Conversation
Can we actually get away with this? I'm not up to speed with what we are doing exactly in the frontent, though I'd be surprised if ALL mutability can be removed (in particular that of the higher level aggregates). |
What do you mean by "higher" lever? The List, Map and Set classes? They are not much more than interfaces and/or abstract base classes for SnakList, StatementList and so on. But you are right, at this point I do not know if this kills our UI code. This still needs investigation where all these methods are used. |
I did a fulltext search for the removed method names in all JavaScript code I have in my local environment. Result: Most are unused, except for what I'm listing below.
|
This is in preparation for wmde/WikibaseDataModelJavaScript#54 Change-Id: I835f6a383305170d2173cdd194c104377765af21
Is this still desired and are you still working on this? You removed this patch from the 3.0 milestone but not #40 so I wonder if I should continue working on that or if we are removing most of the methods anyway. |
|
396fb90
to
723e3fe
Compare
I reverted (almost) all changes to the base interfaces and classes Group, GroupableCollection, List, Map and Set. This should make this much easier to work on. We can remove this in a later patch, if we want. |
723e3fe
to
ed36e13
Compare
No description provided.