Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes for 4.0.0 (dev) #78

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Update release notes for 4.0.0 (dev) #78

merged 1 commit into from
Sep 4, 2017

Conversation

manicki
Copy link
Member

@manicki manicki commented Sep 1, 2017

No description provided.

@thiemowmde
Copy link
Contributor

We piled up some more changes that have not been mentioned in the README so far: #71, and #73. At least #73 is a breaking change and requires a major version bump. I would love to add a few more changes to this release, if possible. At least #74. Possibly (but not necessarily) #40. Can we do this?

@thiemowmde thiemowmde changed the title Release 3.1.0 Release 4.0.0 Sep 1, 2017
@manicki
Copy link
Member Author

manicki commented Sep 4, 2017

Right, I didn't check the master history and didn't notice README is incomplete. To be honest, I don't think I am not going to have a chance to dive into this lib and those open PRs. The only reason I wanted to do the 3.1.0 release was the fact it is required for the following task https://phabricator.wikimedia.org/T171725. I guess I'd rather make a smaller 3.1.0 excluding breaking changes to not block the linked task.

@manicki manicki closed this Sep 4, 2017
@manicki manicki mentioned this pull request Sep 4, 2017
@thiemowmde thiemowmde deleted the rel310 branch September 4, 2017 09:27
@thiemowmde thiemowmde restored the rel310 branch September 4, 2017 09:29
@thiemowmde thiemowmde reopened this Sep 4, 2017
@thiemowmde thiemowmde changed the title Release 4.0.0 Update release notes for 4.0.0 (dev) Sep 4, 2017
@thiemowmde
Copy link
Contributor

@manicki, I updated this pull request to be an update for master, independent from the 3.x branch. Do you think it's ok if I merge this myself?

@manicki manicki merged commit e8d4ed3 into master Sep 4, 2017
@manicki manicki deleted the rel310 branch September 4, 2017 09:36
@manicki
Copy link
Member Author

manicki commented Sep 4, 2017

IMO itt would have been fine if you just pushed it to master even skipping PR as we're not about do the 4.0.0 release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants