-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match the public and private APIs for content reading #386
Conversation
… reflect the public side
…` to `PublicFile`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 54.80% 54.57% -0.23%
==========================================
Files 57 57
Lines 3936 3943 +7
Branches 947 948 +1
==========================================
- Hits 2157 2152 -5
- Misses 1169 1180 +11
- Partials 610 611 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd take this as-is, but while "we have the hood up" and working towards public & private APIs being aligned, would you be up for tackling a small refactor from usize
to u64
for byte offsets? (See the comment)
Co-authored-by: Philipp Krüger <[email protected]> Signed-off-by: Steven Vandevelde <[email protected]>
Summary
I've made it so that the public and private APIs for reading content better match.
wnfs
changes:PrivateFile.get_content
uses itsread_at
method.PublicFile.get_content
to reflect the private side.wnfs-wasm
changes:PrivateFile.read_at
PrivateFile.get_content
uses itsread_at
method.PublicFile.get_content
Test plan (required)
Added and adjusted some tests.
After Merge