Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify WOLFSSL_ROOT location for ESP8266 make builds #7636

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Jun 11, 2024

Description

Applies only to ESP8266 make builds.

Adds clarification in wolfssl_client example for Espressif ESP8266 builds on how the WOLFSSL_ROOT value should be used (relative, not absolute), in both the README and component.mk file comments.

Replaces spaces with tabs in project Makefile

Also updates .gitignore to explicitly:

  • always include Makefile and component.mk files in the /IDE/Espressif path.
  • always exclude sdkconfig.debug and sdkconfig.release files, also in the /IDE/Espressif path.

To aid in identification of path used, addition details are printed at build time. For example:

***********  wolfssl component ************
WOLFSSL_ROOT defined: ../../../../workspace/wolfssl-master
WOLFSSL_ROOT actual:  /mnt/c/workspace/wolfssl-master
********** end wolfssl component **********

Edit:

I've added 20e0e12 as a separate commit to exclude ESP8266 binaries from source files generated by autogen & build process. This allows a freshly cloned wolfssl to be used during RTOS SDK make without these files:

# COMPONENT_OBJS += $(WOLFSSL_ROOT)/wolfcrypt/src/async.o
# COMPONENT_OBJS += $(WOLFSSL_ROOT)/wolfcrypt/src/selftest.o
# COMPONENT_OBJS += $(WOLFSSL_ROOT)/wolfcrypt/src/wolfcrypt_first.o
# COMPONENT_OBJS += $(WOLFSSL_ROOT)/wolfcrypt/src/wolfcrypt_last.o

Once this PR approved, I will create a separate PR for the other examples.

Fixes zd# 18102

Testing

How did you test?

Tested only for the ESP8266, and only manually for in-place, and relocated wolfssl_client build with RTOS SDK make builds.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

jenkins retest this please

@gojimmypi
Copy link
Contributor Author

jenkins retest this please

@SparkiDev SparkiDev requested review from SparkiDev and removed request for wolfSSL-Bot July 15, 2024 23:06
@SparkiDev SparkiDev self-assigned this Jul 15, 2024
@SparkiDev SparkiDev merged commit 56b8ac4 into wolfSSL:master Jul 15, 2024
111 checks passed
@gojimmypi gojimmypi deleted the PR-ESP8266-Make-Clarification branch October 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants