added check if the buf is at least RECORD_HEADER_SZ #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when adding the record headers through quic
douzzer
requested changes
Jun 12, 2024
| @@ -774,6 +780,11 @@ int wolfSSL_quic_receive(WOLFSSL* ssl, byte* buf, word32 sz) | |||
| n = 0; | |||
| if (ssl->quic.input_head) { | |||
| n = quic_record_transfer(ssl->quic.input_head, buf, sz); | |||
|
|
|||
| /* record too small to be fit into a RecordLayerHeader struct. */ | |||
| if (n == -1) { | |||
There was a problem hiding this comment.
n is unsigned here -- but there's a bigger problem, quic_record_transfer() is returning unsigned (word32), but it's returning -1 to signify error.
so you'll need to fix quic_record_transfer() to return sword32, fix signedness clashes that arise from that, and change n in wolfSSL_quic_receive() to be an sword32 and fix clashes that arise from that.
I'm quite surprised none of the analyzers are warning us about return -1 from word32 quic_record_transfer().
douzzer
approved these changes
Jun 13, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 14, 2024
added check if the buf is at least RECORD_HEADER_SZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
should fix this issue.
Testing
Forced it locally (no steps to reproduce were provided), and after some reading of the stacktrace I came up with this quick fix that doesn't require an extensive refactor. Tested like this:
Checklist