20240617-fix-wc_Sha256-overalignment #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionalize alignment optimization of digest and buffer slots on defined(WC_64BIT_CPU), to avoid overalignment warnings on 32 bit targets. this also fixes overalignment of struct Hmac.
This reverts commit b7a28cc. WOLFSSL_AESGCM_STREAM needs to be conditional as arranged by configure.ac.
douzzer
force-pushed
the
20240617-fix-wc_Sha256-overalignment
branch
from
062ad7f to
87114fa
Compare
SparkiDev
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/sha256.h: in definition ofstruct wc_Sha256, conditionalize alignment optimization ofdigestandbufferslots ondefined(WC_64BIT_CPU), to avoid overalignment warnings on 32 bit targets. this also fixes overalignment ofstruct Hmac.see https://www.wolfssl.com/forums/topic2125-armcc-byte-alignment-cannot-be-greater-than-8-bytes-warning.html
ARMCCreportsWith this patch, the alignment of
struct Hmacdrops from 16 to 8 on 32 bit targets.tested with
wolfssl-multi-test.sh ... sanitizer-all-intelasm-c-fallback-fuzzer cross-aarch64-all-armasm-unittest-sanitizer cross-aarch64-all-noasm-unittest-sanitizer cross-armv7a-all-armasm-testsuite-sanitizer super-quick-check