Use proper ref count handling when adding to x509 store #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
reviewed
Nov 27, 2024
ColtonWilley
changed the title
… signed trusted CA
ColtonWilley
changed the title
julek-wolfssl
previously requested changes
Dec 3, 2024
|
Retest this please. |
SparkiDev
approved these changes
Dec 10, 2024
douzzer
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
this all LGTM.
A separate issue, which you probably noticed yourself, is that we have a wolfSSL_X509_up_ref() but no corresponding wolfSSL_X509_down_ref(). Hence, the *free() routines need to use ad hoc wolfSSL_RefDec(&store->ref, ...) calls.
Cleanup opportunity for another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use proper ref count handling when adding to x509 store
Fixes github issue #8222