Aarch64 ASM: Use CPU features for more #8325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AES GCM streaming - fix GHASH_ONE_BLOCK to use CPU feature information. AES-GCM uses EOR3 (SHA-3 instruction) - split assembly code. Kyber uses SQRDMLSH - split assembly code. Changed define from WOLFSSL_AARCH64_NO_SQRMLSH to WOLFSSL_AARCH64_NO_SQRDMLSH to match instruction. Improved array data format for inline assembly code.
dgarske
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the scope of the fix or feature addition.
AES GCM streaming - fix GHASH_ONE_BLOCK to use CPU feature information. AES-GCM uses EOR3 (SHA-3 instruction) - split assembly code. Kyber uses SQRDMLSH - split assembly code.
Changed define from WOLFSSL_AARCH64_NO_SQRMLSH to
WOLFSSL_AARCH64_NO_SQRDMLSH to match instruction.
Improved array data format for inline assembly code.
Testing
Regression tested Aarch64 assembly code.
Checklist