Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support elevation and time #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamMeuli
Copy link

Use appropriate types for:

  • elevation (QVariant.Double)
  • capture_time (QVariant.DateTime)

@sfkeller
Copy link

Resolves also #6 ?!

@wondie
Copy link
Owner

wondie commented Dec 18, 2024

@SamMeuli thank you very much for the pull request! I will test it soon and merge. @sfkeller did you test the pull request?

@sfkeller
Copy link

sfkeller commented Dec 18, 2024

@SamMeuli thank you very much for the pull request! I will test it soon and merge. @sfkeller did you test the pull request?

Yes. My test is as follows: For testing the z values I used to the GPX files from #6, and for testing the datetime I took any GPX file and tried to animate it using "temporal properties" (the built-in time manager), see https://docs.qgis.org/3.34/en/docs/user_manual/working_with_vector/vector_properties.html#temporal-properties

@wondie
Copy link
Owner

wondie commented Dec 19, 2024

@SamMeuli could you make your pull request to https://github.com/wondie/batch_gps_importer/tree/rel_1_1_0. I will add all fixes and enhancements there and if it is all good, I will merge it to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants