Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALL] frontend CI 수정 #380

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[ALL] frontend CI 수정 #380

merged 1 commit into from
Sep 27, 2024

Conversation

Largopie
Copy link
Contributor

@Largopie Largopie commented Sep 27, 2024

관련 이슈

작업 내용

카카오 SDK 스크립트에 async속성은 추가하지 않기로 결정되었습니다. 이유는 이슈에 추가적으로 등록해두었습니다.

  • async 속성으로 인해 SDK와 연관된 컴포넌트 로직이 SDK보다 먼저 불러와지는 현상으로 인해 에러가 발생하여 async 속성은 추가하지 않기로 결정되었습니다.

  • 카카오 SDK 스크립트에 async 속성 추가

  • frontend CI 동작 브랜치 추가

특이 사항

리뷰 요구사항 (선택)

@Largopie Largopie added 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) ♻️ 리팩터링 코드를 깎아요 :) labels Sep 27, 2024
@Largopie Largopie added this to the 5차 데모데이 milestone Sep 27, 2024
@Largopie Largopie self-assigned this Sep 27, 2024
Copy link

Test Results

9 tests   9 ✅  10s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit d825afc.

@Largopie Largopie changed the title [FE] 카카오 SDK 스크립트 비동기로 실행하도록 수정 [FE] 카카오 스크립트 수정 및 frontend CI 수정 Sep 27, 2024
@hw0603
Copy link
Member

hw0603 commented Sep 27, 2024

Sounds good.👍

@Largopie Largopie changed the title [FE] 카카오 스크립트 수정 및 frontend CI 수정 [FE] 카카오 스크립트 및 frontend CI 수정 Sep 27, 2024
Copy link
Contributor

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Copy link
Contributor

@ehBeak ehBeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에요👍

@Largopie Largopie changed the title [FE] 카카오 스크립트 및 frontend CI 수정 [FE] frontend CI 수정 Sep 27, 2024
@Largopie Largopie changed the title [FE] frontend CI 수정 [ALL] frontend CI 수정 Sep 27, 2024
@Largopie Largopie force-pushed the refactor/379-kakao-sdk branch from d825afc to 34eab95 Compare September 27, 2024 11:16
@Largopie Largopie merged commit 17d61f4 into develop Sep 27, 2024
4 checks passed
@Largopie Largopie deleted the refactor/379-kakao-sdk branch October 4, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ 리팩터링 코드를 깎아요 :) 🐈 프론트엔드 프론트엔드 관련 이슈에요 :)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[ALL] frontend CI main 브랜치 merge 시에도 동작하도록 수정해요 :)
4 participants