Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 엔드포인트에서 사용하지 않는 session ID가 있으면, 없애고 새로운 엔드포인트 생성 #1549

Merged
merged 2 commits into from
Sep 25, 2023
Merged

refactor : 엔드포인트에서 사용하지 않는 session ID가 있으면, 없애고 새로운 엔드포인트 생성 #1549

merged 2 commits into from
Sep 25, 2023

Conversation

java-saeng
Copy link
Contributor

#️⃣연관된 이슈

📝작업 내용

  • 기존 기능은 놔두고 newXXX 가 session ID가 없는 메서드
  • 추후 기존 기능을 삭제하고, newXXX 메서드를 사용할 예정

@java-saeng
refactor : session ID 를 없애는 작업 기능
ebfb427 
- 기존 기능은 놔두고 newXXX 가 session ID가 없는 메서드
- 추후 기존 기능을 삭제하고, newXXX 메서드를 사용할 예정
@java-saeng java-saeng added the BE label Sep 20, 2023
@java-saeng java-saeng self-assigned this Sep 20, 2023
@java-saeng java-saeng changed the title refactor : session ID 를 없애는 작업 기능 refactor : 엔드포인트에서 사용하지 않는 session ID가 있으면, 없애고 새로운 엔드포인트 생성 Sep 20, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

nuyh99
nuyh99 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nuyh99 nuyh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용!

amaran-th
amaran-th approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 크게 수정할 부분은 없는 것 같네요~~

@java-saeng java-saeng merged commit 81c2e33 into roadmap-develop Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuyh99 nuyh99 nuyh99 approved these changes

@amaran-th amaran-th amaran-th approved these changes

@BGuga BGuga Awaiting requested review from BGuga

Assignees

@java-saeng java-saeng

Labels
BE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@java-saeng @amaran-th @nuyh99