Skip to content

Commit

Permalink
Use ops-deploy Slack channel for release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
MathieuLamiot committed Oct 23, 2024
1 parent cba650b commit f44cf46
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion config/slack.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"dev-team-escalation-channel": "C056ZJMHG0P",
"engineering-service-team-channel": "C069W48E47N",
"release-channel" : "C05PGTQHHJ9",
"ops-channel": "C88N0811V"
"ops-channel": "C88N0811V",
"ops-deploy-channel": "C07SXUKRSLE"
}
2 changes: 2 additions & 0 deletions sources/factories/SlackMessageFactory.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ def get_channel(self, flow):
return self.slack_config["release-channel"]
if 'ops' == flow:
return self.slack_config["ops-channel"]
if 'ops-deploy' == flow:
return self.slack_config["ops-deploy-channel"]
raise ValueError('Unknown flow for get_channel.')

def get_release_note_review_blocks(self, text):
Expand Down
2 changes: 1 addition & 1 deletion sources/handlers/GithubReleaseHandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ def process_release(self, app_context, release_params):
blocks = self.slack_message_factory.get_release_note_review_blocks(text)

self.slack_message_factory.post_message(app_context,
self.slack_message_factory.get_channel('ops'),
self.slack_message_factory.get_channel('ops-deploy'),
text, blocks)

0 comments on commit f44cf46

Please sign in to comment.