Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #765: Imagify plugin banners are not styled #768

Merged

Conversation

jeawhanlee
Copy link
Contributor

Description

This PR fixes the unstyled banners of imagify.

Fixes #765

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@jeawhanlee jeawhanlee added this to the 2.1.4 milestone Dec 21, 2023
@jeawhanlee jeawhanlee self-assigned this Dec 21, 2023
@jeawhanlee jeawhanlee marked this pull request as ready for review December 21, 2023 07:56
@jeawhanlee jeawhanlee requested a review from a team December 21, 2023 07:56
@CrochetFeve0251 CrochetFeve0251 added this pull request to the merge queue Dec 28, 2023
Merged via the queue into develop with commit cce86a6 Dec 28, 2023
7 checks passed
@CrochetFeve0251 CrochetFeve0251 deleted the enhancement/765-imagify-plugin-banners-are-not-styled branch December 28, 2023 14:10
@remyperona remyperona removed this from the 2.1.4 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imagify plugin banners are not styled
4 participants