Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add league/container, event-manager to composer and mozart #782

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Add league/container, event-manager to composer using mozart.

Fixes #776

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

Copy link
Contributor

@remyperona remyperona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event manager import into the dependencies is missing currently

@Khadreal
Copy link
Contributor Author

The event manager import into the dependencies is missing currently

Fixed

@Khadreal Khadreal requested a review from remyperona January 16, 2024 21:11
@remyperona remyperona changed the base branch from develop to feature/avif January 18, 2024 21:53
@remyperona remyperona merged commit 188264f into feature/avif Jan 18, 2024
6 of 7 checks passed
@remyperona remyperona deleted the feature/776-avif-container branch January 18, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF support: container & event manager
3 participants