-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed imagify pricing modal layout issue #924
Conversation
@Khadreal Thanks for the update. currently the banner is not displayed at gravity form with no conflict on. However, the upgrade btn is not working (even if gravity form is disabled). can you please check 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding the 3rd party compatibility with procedural code instead of a new class?
PHP Stan check is failing as well. |
@wp-media/engineering-team do we need this enhancement considering this fix? |
@piotrbak The issue is still there on dev after merging 945 |
I'm testing this now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Job @Khadreal
@wordpressfan Would be good to see if the modal appears correctly when upgrading also |
If so, it can be merged I believe |
Yes it's working imagify-gravityforms-part2-2024-12-19_20.02.30.mp4 |
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixed issue with imagify pricing modal disrupting other pages.
Fixes #919
Type of change
Detailed scenario
Technical description
Add a check to pricing modal to show up only on imagify admin pages only.
Documentation
Explain how this code works. Diagrams & drawings are welcome.
Mandatory Checklist
Code validation
Code style