Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed imagify pricing modal layout issue #924

Merged
merged 18 commits into from
Dec 20, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Nov 19, 2024

Description

Fixed issue with imagify pricing modal disrupting other pages.

Fixes #919

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

  • Install and activate the latest imagify
  • Install and activate visual composer
  • Edit the homepage in Visual Composer or create any page

Technical description

Add a check to pricing modal to show up only on imagify admin pages only.

Documentation

Explain how this code works. Diagrams & drawings are welcome.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Khadreal Khadreal self-assigned this Nov 19, 2024
@Khadreal Khadreal requested a review from a team November 19, 2024 09:58
@MathieuLamiot MathieuLamiot linked an issue Nov 20, 2024 that may be closed by this pull request
@Mai-Saad
Copy link

@Khadreal Thanks for the update. currently the banner is not displayed at gravity form with no conflict on. However, the upgrade btn is not working (even if gravity form is disabled). can you please check 🙏

@Khadreal Khadreal requested review from Miraeld and a team December 17, 2024 12:12
Copy link
Contributor

@remyperona remyperona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding the 3rd party compatibility with procedural code instead of a new class?

@Khadreal Khadreal requested a review from remyperona December 18, 2024 11:12
classes/ThirdParty/Plugins/GravityForms.php Outdated Show resolved Hide resolved
classes/ThirdParty/Plugins/GravityForms.php Outdated Show resolved Hide resolved
classes/ThirdParty/Plugins/GravityForms.php Outdated Show resolved Hide resolved
@jeawhanlee
Copy link
Contributor

PHP Stan check is failing as well.

@Khadreal Khadreal requested a review from jeawhanlee December 18, 2024 14:44
classes/ThirdParty/Plugins/GravityForms.php Outdated Show resolved Hide resolved
classes/ThirdParty/Plugins/GravityForms.php Outdated Show resolved Hide resolved
inc/classes/class-imagify-views.php Outdated Show resolved Hide resolved
@piotrbak
Copy link

@wp-media/engineering-team do we need this enhancement considering this fix?
#945

CC @engahmeds3ed

@Mai-Saad
Copy link

@piotrbak The issue is still there on dev after merging 945
Screenshot from 2024-12-19 15-36-47

@wordpressfan
Copy link
Contributor

I'm testing this now...

Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Job @Khadreal

@wordpressfan
Copy link
Contributor

I tested the issue with gravity forms and it's working properly:

imagify-gravityforms-2024-12-19_19.38.34.mp4

I can see that it's Test by dev, should we merge this one directly?
@piotrbak @Mai-Saad

@piotrbak
Copy link

@wordpressfan Would be good to see if the modal appears correctly when upgrading also

@piotrbak
Copy link

If so, it can be merged I believe

@wordpressfan
Copy link
Contributor

Yes it's working

imagify-gravityforms-part2-2024-12-19_20.02.30.mp4

@piotrbak
Copy link

Looks good!

Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mai-Saad Mai-Saad added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 260a3cc Dec 20, 2024
9 checks passed
@Mai-Saad Mai-Saad deleted the fix/pricing-modal-layout-issues branch December 20, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with gravity forms noconflict mode
7 participants