Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0 #125

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

v3.0 #125

wants to merge 18 commits into from

Conversation

remyperona
Copy link
Contributor

  • Update container and lazyload library to version 3
  • Update plugin version to 3.0, minimum PHP to 7.0, minimum WP to 5.4
  • Code cleanup

@remyperona remyperona requested a review from a team October 1, 2021 20:21
@remyperona remyperona self-assigned this Oct 1, 2021
@remyperona remyperona linked an issue Oct 1, 2021 that may be closed by this pull request
$lazy_sources triggers a undefined variable PHP notice #123
Open
@remyperona remyperona requested a review from a team October 4, 2021 14:50
@Mai-Saad Mai-Saad self-requested a review October 15, 2021 05:29
@Mai-Saad
Copy link

Mai-Saad commented Oct 15, 2021 •
edited
Loading

@Tabrisrp I think we need to update the readme file, what do you think? we need to handle iframe as well to be working as same as the trunk (if we used preview image, the image won't be displayed in UI + LL classes won't be added in inspect view) 🙏

@remyperona
Copy link
Contributor Author

@Mai-Saad readme is updated already.

Can you show me an example of the case you describe?

@remyperona
Copy link
Contributor Author

@Mai-Saad Following up on the reported issue, the latest commits fix it. The preview image should be correctly displayed now when using the preview image for Youtube videos, and the image has the loading="lazy" attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mai-Saad Mai-Saad Mai-Saad left review comments

@iCaspar iCaspar iCaspar approved these changes

Assignees

@remyperona remyperona

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$lazy_sources triggers a undefined variable PHP notice
3 participants
@remyperona @Mai-Saad @iCaspar