-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LRC functionality #20
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we work on the code coverage with tests on this PR?
I think this is not blocking for testing 3.17 and moving forward as we already have a merged version of the script into WP Rocket.
But before validating the PR on the rocket-scripts side, increasing code coverage would be good.
I opened a GitHub issue for this, linked to this PR too. #23
…nly below the fold
This reverts commit b4f633b.
Depend on php to identify which elements to be saved
…tion Consider viewport on element distance calculation
…crease-coverage-of-3.17 # Conflicts: # src/BeaconLrc.js
…ease-coverage-of-3.17 Closes #23: Add tests to increase coverage of 3.17
Description
Fixes #7
Documentation
User documentation
Explain how this code impacts users.
Technical documentation
Explain how this code works. Diagram & drawings are welcomed.
Type of change
Delete options that are not relevant.
New dependencies
List any new dependencies that are required for this change.
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Documentation
Code style
Observability
Risks