Closes #31: Add a check if page is scrolled down. #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31
This PR adds a check to ensure that the beacon is not fired if the page is scrolled down before it runs.
Type of change
Detailed scenario
Technical description
Documentation
The
_isPageScrolled()
method is used inBeaconManager.js
to check if the page is scrolled and bails out if it returns true. In-build test have been added as well.New dependencies
None
Risks
None
Mandatory Checklist
Code validation
Code style
Additional Checks