Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6728 Largest element with a background-image that is not kept #33

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Oct 8, 2024

Description

Fixed the issue with LCP when background-image has gradient

Fixes wp-media/wp-rocket#6728

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check scenario here

Technical description

Improve the beaconLCP script to capture valid image after background-image gradient.

Documentation

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Oct 8, 2024
Copy link

codacy-production bot commented Oct 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+6.70% (target: -1.00%) 42.86% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (78ca211) 578 349 60.38%
Head commit (7a343c5) 641 (+63) 430 (+81) 67.08% (+6.70%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#33) 7 3 42.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal requested a review from a team October 8, 2024 12:50
@jeawhanlee
Copy link
Contributor

Good Job here Sir
Can we also update related test case?

@piotrbak
Copy link

@Khadreal Is this one still in progress?

@Khadreal
Copy link
Contributor Author

@Khadreal Is this one still in progress?

Nope

Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khadreal, thank you for this PR.
Finished exploratory and also executed TP and all looks good on the test env.
Tests Results report below:
testrail-report-647.pdf

@Khadreal Khadreal merged commit b612364 into develop Oct 15, 2024
4 of 6 checks passed
@Khadreal Khadreal deleted the enhancement/6728-largest-element-background branch October 16, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants