Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop clearing cache when incompatible plugins list is updated #6166

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

engahmeds3ed
Copy link
Contributor

Description

As groomed.

Fixes #6077

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No, exactly the same.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@engahmeds3ed engahmeds3ed self-assigned this Sep 15, 2023
@engahmeds3ed engahmeds3ed marked this pull request as ready for review September 20, 2023 12:56
@engahmeds3ed engahmeds3ed requested a review from a team September 20, 2023 12:56
@engahmeds3ed
Copy link
Contributor Author

For the tests, I invested some time trying to add them quickly but I found that we now only test the default lists so we need to refactor those tests to be able to test the cache clear functionality with incompatible plugins only in a better way.

For that I created this issue not to forget about it: #6180

@vmanthos vmanthos self-requested a review September 21, 2023 05:35
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! 🙏 🎩

@vmanthos vmanthos added this to the 3.15.1 milestone Sep 21, 2023
@vmanthos vmanthos added this pull request to the merge queue Sep 21, 2023
Merged via the queue into develop with commit d99e1af Sep 21, 2023
8 checks passed
@vmanthos vmanthos deleted the fix/6077-incompatible-plugins-list-clear-cache branch September 21, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The whole cache is cleared when the incompatible plugins dynamic list is the only one updated
3 participants