Closes #6152: Add license type to what is reported to Mixpanel

[Miraeld]

Description

This will help see how representative is the current sample from opted-in users vs our current users and how reliable data collected from them to help with product decisions.

A new function has been created that returns the type of license. As this functionality is used in different files, it has been modified to use the newly created function.

Fixes #6152

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

Yes

Checklists

Generic development checklist

• My code follows the style guidelines of this project, with adapted comments and without new warnings.
• I have added unit and integration tests that prove my fix is effective or that my feature works.
• The CI passes locally with my changes (including unit tests, integration tests, linter).
• Any dependent changes have been merged and published in downstream modules.
• If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
• I validated all test plan the QA Review asked me to.

[engahmeds3ed]

Good job @Miraeld in ur first PR.

I didn't fully review it yet but I noticed this important point.

Also plz run the command

composer phpcs:fix

to automatically fix most of those reported coding standard issues.

[remyperona]

The code needs to be updated to follow our coding standards (errors are available in the CS GH action)

[engahmeds3ed]

Minor adjustments

[vmanthos]

@Miraeld Thank you for the PR!
I see the license_type is added to the data sent to Mixpanel. 👍

@wp-media/productrocket The new info that will be collected is not listed here:

Also, the CTA (Activate Rocket Analytics) is displayed even when Rocket Analytics is enabled.

Please confirm (or not) that:

1. The license type info should be included in the data collection table.
2. The CTA should not be displayed if Rocket Analytics is already enabled.

[DahmaniAdame]

The license type info should be included in the data collection table.

Yes, it should show.

The CTA should not be displayed if Rocket Analytics is already enabled.

No, there is no need to redisplay it if the consent is already given.

[vmanthos]

@Miraeld Thank you for the fixes.

The CTA button is not displayed but with that, the following text is hidden as well:

Since that's a disclaimer notice it should stay in place.

Also, and this is a late notice on my part, there is inconsistency in how various info is displayed as far as the used fonts go:

This has to do with some of it being wrapped in <code></code> and that results in the use of a monospace font.

Unless there is a specific reason to have some part in <code>, maybe we can go with a uniform look there.

@DahmaniAdame What's your take on this?

[DahmaniAdame]

@vmanthos yes, uniformizing it is the way to go.
code looks nicer, but not consistent and practical (doesn't look good when lines are wrapped).
Uniformizing it without the code would make sense.

[Miraeld]

@vmanthos I've corrected the cta, now only the button is not displayed once rocket analytics is enabled.

@vmanthos @DahmaniAdame I've taken off the <code></code> tags to standardize the formatting.

[vmanthos]

Thank you for the fixes, @Miraeld !

This is working as expected. 👍