Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Background-image lazy-loading with WPML #6191

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix Background-image lazy-loading with WPML #6191

merged 2 commits into from
Sep 29, 2023

Conversation

mostafa-hisham
Copy link
Contributor

@mostafa-hisham mostafa-hisham commented Sep 27, 2023 •
edited
Loading

Description

Fix background-image lazy-loading with WPML by using the correct URL without the translation

Fixes #6178

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

I couldn't test WPML domain base setup locally but it should work

@mostafa-hisham mostafa-hisham marked this pull request as ready for review September 27, 2023 08:32
@mostafa-hisham mostafa-hisham requested a review from a team September 27, 2023 08:32
@mostafa-hisham mostafa-hisham self-assigned this Sep 27, 2023
@vmanthos vmanthos self-requested a review September 28, 2023 09:05
vmanthos
vmanthos approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected! 👍

@vmanthos vmanthos added this pull request to the merge queue Sep 29, 2023
@vmanthos vmanthos added this to the 3.15.2 milestone Sep 29, 2023
Merged via the queue into develop with commit bb1cfe5 Sep 29, 2023
8 checks passed
@vmanthos vmanthos deleted the fix/6178-WPML-bg-image-lazy-loading branch September 29, 2023 11:02
Miraeld pushed a commit that referenced this pull request Oct 5, 2023
@mostafa-hisham @vmanthos
fix Background-image lazy-loading with WPML (#6191)
132d5fe 
Co-authored-by: Vasilis Manthos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeawhanlee jeawhanlee jeawhanlee approved these changes

@vmanthos vmanthos vmanthos approved these changes

Assignees

@mostafa-hisham mostafa-hisham

Labels
None yet
Projects
None yet
Milestone
3.15.2
Development

Successfully merging this pull request may close these issues.

Background-image lazy-loading not compatible with WPML
3 participants
@mostafa-hisham @vmanthos @jeawhanlee