Closes #6329: Deprecate RUCSS Hooks

[jeawhanlee]

Description

This PR deprecates the use of RUCSS hooks.

Fixes #6329

Type of change

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

• My code follows the style guidelines of this project, with adapted comments and without new warnings.
• I have added unit and integration tests that prove my fix is effective or that my feature works.
• The CI passes locally with my changes (including unit tests, integration tests, linter).
• Any dependent changes have been merged and published in downstream modules.
• If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
• I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

[CrochetFeve0251]

@Tabrisrp when I worked with @jeawhanlee on that seemed like the function was a good but after a while and remembering @piotrbak idea seems like it looked like the moment to create a class for filters and actions.

This would abstract the wiring between the old and new hooks at the level of the business logic and we would be able to add casting directly within the apply_filters method.

The idea is to create a Filter and an Action class.

Then in the deprecated file we reuse that classes to make the link between old and new hooks with something like (This is possible as deprecated logic is loaded after the container is loaded):

$filter->add_deprecated('old_hook', 'new_hook');

And inside the Filter and Action class we add an abstract logic to make the links based on an array and call the deprecated filter function.So inside the main logic we would have:

$result = $this->filter->apply_filter('new_hook', $param);

Concerning the casting issue we could create a method apply_string_filter , apply_int_filter for each base type and a method apply_filter with a callback for validation as second parameter so we would cover each cases.

What do you think @Tabrisrp, @piotrbak ?

[wordpressfan]

@CrochetFeve0251 I like that idea so much, but I believe we need to use those new classes gradually because we have so many apply_filters and do_action in our code base.

[jeawhanlee]

List of Deprecated Hooks

• rocket_last_rucss_job_added_time -> rocket_last_saas_job_added_time
• rocket_rucss_delete_interval -> rocket_saas_delete_interval
• rocket_rucss_pending_jobs_cron_interval -> rocket_saas_pending_jobs_cron_interval
• rocket_remove_rucss_failed_jobs_cron_interval -> rocket_remove_saas_failed_jobs_cron_interval
• rocket_remove_rucss_on_submit_jobs_cron_interval -> rocket_remove_saas_on_submit_jobs_cron_interval
• rocket_rucss_deletion_enabled -> rocket_saas_deletion_enabled
• rocket_rucss_process_pending_jobs_start -> rocket_saas_process_pending_jobs_start
• rocket_rucss_process_pending_jobs_end -> rocket_saas_process_pending_jobs_end
• rocket_rucss_check_job_status_end -> rocket_saas_check_job_status_end
• rocket_rucss_complete_job_status -> rocket_saas_complete_job_status
• rocket_rucss_process_on_submit_jobs_start -> rocket_saas_process_on_submit_jobs_start
• rocket_rucss_pending_jobs_cron_rows_count -> rocket_saas_pending_jobs_cron_rows_count
• rocket_rucss_max_pending_jobs -> rocket_saas_max_pending_jobs
• rocket_rucss_process_on_submit_jobs_end -> rocket_saas_process_on_submit_jobs_end
• rocket_delay_remove_rucss_failed_jobs -> rocket_delay_remove_saas_failed_jobs
• rocket_rucss_retry_table -> rocket_saas_retry_table
• rocket_rucss_retry_duration -> rocket_saas_retry_duration
• rocket_rucss_is_home_url -> rocket_saas_is_home_url

[MathieuLamiot]

@piotrbak FYI. Do you need anything from the team about this? I think support and maybe public docs needs to be updated?