Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container fatal errors with activation and deactivation #6567

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

wordpressfan
Copy link
Contributor

Description

@Mai-Saad reported a fatal error with lcp branch and after checking I found that the issue also happens with develop, it's a leftover from this PR: #6542

This fatal error was happening with activation and deactivation of WPR.

@wordpressfan wordpressfan self-assigned this Apr 17, 2024
@wordpressfan wordpressfan requested a review from a team April 17, 2024 09:26
Copy link
Contributor

@Khadreal Khadreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for abee9d81 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (abee9d8) Report Missing Report Missing Report Missing
Head commit (cd4facf) 35980 8356 23.22%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6567) 9 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan wordpressfan added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 3cbd492 Apr 17, 2024
9 of 11 checks passed
@wordpressfan wordpressfan deleted the fix/activation-deactivation-fatal-errors branch April 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants