Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6576 Add safe guard for links limit filter value in warmup #6580

Merged

Conversation

remyperona
Copy link
Contributor

Description

Add a default value used as safe guard for the links limit filter value in warmup, if the returned value is not a int or is inferior to 1

Fixes #6576

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

@remyperona remyperona added type: bug Indicates an unexpected problem or unintended behavior lcp labels Apr 22, 2024
@remyperona remyperona added this to the 3.16 milestone Apr 22, 2024
@remyperona remyperona requested a review from a team April 22, 2024 19:41
@remyperona remyperona self-assigned this Apr 22, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 80.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (af00697) 36824 8216 22.31%
Head commit (0b1dede) 36827 (+3) 8218 (+2) 22.32% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6580) 5 4 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@MathieuLamiot
Copy link
Contributor

Ran the "How to reproduce" from the issue manually. all good ✅

@MathieuLamiot MathieuLamiot merged commit 2486a81 into feature/lcp-above-the-fold-optimization Apr 24, 2024
12 checks passed
@MathieuLamiot MathieuLamiot deleted the fix/6576-guard-filter branch April 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
3 participants